-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing flags in Makefile and compatible changes to workflow #19
Conversation
非常感谢!@CookiePieWw 既然进行了这方面的修改,我还有以下提议以完善本 PR:
以上三点我认为可以考虑。直到 @CookiePieWw 表达对上述提议的看法前,本 PR 暂不合入。 |
感谢 @skyleaworlder 的 review。 对 makefile 和 README.md 作了相应修改。对于 make.bat,由于我这里没有 win 的编译环境,因此只能尝试修改并使用 workflow 检查,不知道是什么原因,目前还无法成功生成 pdf 并上传。您对此有什么看法呢? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
或许应该是这里的问题,由于目前我也不是很方便,所以也很难测试。
不断尝试修复 CI 并使之通过的过程是非常痛苦的,我非常理解,真是麻烦同学了!
再次感谢 @CookiePieWw ! 修复 CI 在 GitHub Actions 上始终是一件痛苦的事情,感谢你对 |
No description provided.