Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leetcode binary tree maximum path sum and leetcode largest rectangle … #36

Merged
merged 3 commits into from
Oct 2, 2021

Conversation

sparsh9
Copy link

@sparsh9 sparsh9 commented Oct 1, 2021

…in histogram

Hey there!, Thanks for submitting a PR to this repo
Please complete the following checklist for your PR to be approved. Mark the items by adding an x.
Example: - [ ] Mark me as completed
To mark: - [x] Mark me as completed

  • My Pull Request adheres to the Contribution guidelines.
  • I have added readme.md and solution files in the appropriate folder.
  • The solution I have given is my own and not plagiarized in any form.
  • My solution passes all the testcases.
  • I have properly indented and documented my solution using comments.

If any of the above is unmarked, please make the necessary changes and then mark them so that you're PR can be approved and merged.

@welcome
Copy link

welcome bot commented Oct 1, 2021

Congrats on submitting your first Pull Request here! 🎉 🎉
Your PR would be reviewed by a maintainer soon ✔️
In the meantime, ⭐ star this repo and check out our Instagram page if you wanna learn more about CP & DSA! 😃

Copy link
Collaborator

@GrrrGe GrrrGe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comments to your solutions explaining the logic as mentioned in the contribution guidelines.

@sparsh9
Copy link
Author

sparsh9 commented Oct 1, 2021

Okay will add comments.

@sparsh9
Copy link
Author

sparsh9 commented Oct 1, 2021

I have added the comments, please check.

@tomthomasvempala tomthomasvempala added the changes-needed make the necessary changes label Oct 1, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 1, 2021

Hey there, please add comments to your solution as mentioned in the Contributing guidelines for your PR to be approved.

@tomthomasvempala
Copy link
Collaborator

I have added the comments, please check.

couldnt find your changes.. did u commit again?

@sparsh9
Copy link
Author

sparsh9 commented Oct 1, 2021

Sorry for the inconvenience caused, please check now.

@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2021

Awesome 👍, Thanks for contributing to Hack-CP-DSA by TLE MEC 😃!

@mergify mergify bot removed the changes-needed make the necessary changes label Oct 2, 2021
@mergify mergify bot merged commit 37a9d24 into TLE-MEC:main Oct 2, 2021
@Vishruth-S Vishruth-S added the hacktoberfest-accepted Accepted for hacktoberfest label Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants