Numerous fixes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- buffer-face-mode is unnecessary - Use conf-mode to set up comment behaviour and font lock defaults - Overriding the user's preferences for completion behaviour and mechanisms is inappropriate: removed. - Overriding the user's electric pair preferences is inappropriate: removed. - Fix code that was breaking the global syntax table (calling modify-syntax-table without a table arg) - Misc small fixes & improvements
5 tasks
|
(P.S. Tested this with an example file found at http://download.vikis.lt/doc/perl-Config-General-2.52/example.cfg) |
|
Ok, thank you for your work, so I need to put all this stuff into my config then, well. Thank you very much @purcell 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than try to explain what was necessary here, I sat down and fixed a bunch of stuff. These commits make config-general-mode use conf-mode appropriately, which should solve some of your confusion about why things weren't working.
Additionally, all the code for overriding the user's electric pair and completion behaviour was inappropriate, so I've removed it. All of that belongs in your personal config, not in a major mode: for example, if a user wants "indent or complete" behaviour on TAB, they can
(setq tab-always-indent 'complete)globally (or in a mode hook if preferred), and this will work with whatever completion mechanism they prefer. Same withelectric-pair-mode.As a result of all this, the code is much shorter and hopefully more correct and reliable. Hope this helps!