ViolationStoreFactory throws StoreUpdateFailedException when previous run = 0 violations

[jbkervyn]

First run : no violations : emtpy file created.
Second run : no violations : StoreUpdateFailedException

CategorizedViolations the following :

this leads to removeObsoleteViolationsFromStore being called and this can trigger an StoreUpdateFailedException

[hankem]

Thanks for the report! I can indeed reproduce the issue with the following simple example:

imports

import com.tngtech.archunit.ArchConfiguration;
import com.tngtech.archunit.junit.AnalyzeClasses;
import com.tngtech.archunit.junit.ArchTest;
import com.tngtech.archunit.junit.ArchUnitRunner;
import com.tngtech.archunit.lang.ArchRule;
import org.junit.runner.RunWith;

import static com.tngtech.archunit.lang.syntax.ArchRuleDefinition.classes;
import static com.tngtech.archunit.library.freeze.FreezingArchRule.freeze;

@RunWith(ArchUnitRunner.class)
@AnalyzeClasses(packagesOf = Issue456.class)

public class Issue456 {
    static {
        ArchConfiguration.get().setProperty("freeze.store.default.allowStoreCreation", "true");
        ArchConfiguration.get().setProperty("freeze.store.default.allowStoreUpdate", "false");
    }

    ArchRule ruleWithoutViolations = classes().should().haveNameMatching(".*");

    @ArchTest
    ArchRule frozen = freeze(ruleWithoutViolations);
}