-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement composite rules, joined via and() #128
Conversation
Thanks a lot 😃 Looks generally good, I've added some minor comments. Also as you can see, the tests have failed. These are ArchUnit's own ArchUnit tests 😉 that want that you add Also it would be great if you could check out https://github.com/TNG/ArchUnit/blob/master/CONTRIBUTING.md |
PS: Rebasing would be awesome, too 😉 I generally like a linear history where possible... |
Hi, thanks for the feedback! Where can I find your comments? Can't see them in the 'Files Changed' section. And yeah, I really should have read this document before :D |
...ple/example-plain/src/test/java/com/tngtech/archunit/exampletest/CompositeArchRulesTest.java
Outdated
Show resolved
Hide resolved
...integration-test/src/test/java/com/tngtech/archunit/integration/ExamplesIntegrationTest.java
Outdated
Show resolved
Hide resolved
archunit/src/main/java/com/tngtech/archunit/lang/CompositeArchRule.java
Outdated
Show resolved
Hide resolved
archunit/src/main/java/com/tngtech/archunit/lang/CompositeArchRule.java
Outdated
Show resolved
Hide resolved
archunit/src/main/java/com/tngtech/archunit/lang/CompositeArchRule.java
Outdated
Show resolved
Hide resolved
archunit/src/main/java/com/tngtech/archunit/lang/CompositeArchRule.java
Outdated
Show resolved
Hide resolved
Ah sorry, I forgot to click "submit review" 😳 |
1051e3b
to
ab6f1cd
Compare
6669fe5
to
16bad98
Compare
I've added support for priorities to |
Implement composite rules, joined via and()
Bumps [jemoji](https://github.com/jekyll/jemoji) from 0.12.0 to 0.13.0. # Changelog Sourced from [jemoji's changelog](https://github.com/jekyll/jemoji/blob/master/History.markdown). > ## v0.13.0 / 2022-11-19 > -------------------- > > ### Development Fixes > > * Add Actions CI workflow ([#127](https://github-redirect.dependabot.com/jekyll/jemoji/issues/127)) > * Add release workflow ([#128](https://github-redirect.dependabot.com/jekyll/jemoji/issues/128)) > * Create dependabot config for rubygems upgrades ([#126](https://github-redirect.dependabot.com/jekyll/jemoji/issues/126)) > * Add github-actions to dependabot ([#132](https://github-redirect.dependabot.com/jekyll/jemoji/issues/132)) > * Bump actions/checkout from 2 to 3 ([#133](https://github-redirect.dependabot.com/jekyll/jemoji/issues/133)) > * Upgrade Rubocop target version to 2.7 ([#134](https://github-redirect.dependabot.com/jekyll/jemoji/issues/134)) > * Update rake requirement from ~> 12.0 to ~> 13.0 ([#130](https://github-redirect.dependabot.com/jekyll/jemoji/issues/130)) > > ### Minor Enhancements > > * Update gemoji requirement from ~> 3.0 to >= 3, < 5 & test with both major versions ([#131](https://github-redirect.dependabot.com/jekyll/jemoji/issues/131)) # Commits * [`1443020`](jekyll/jemoji@1443020) Merge pull request [#135](https://github-redirect.dependabot.com/jekyll/jemoji/issues/135) from jekyll/release-1-0-0 * [`6934e3d`](jekyll/jemoji@6934e3d) Release jemoji v0.13.0 * [`d766153`](jekyll/jemoji@d766153) Update history to reflect merge of [#131](https://github-redirect.dependabot.com/jekyll/jemoji/issues/131) \[ci skip\] * [`b251fd9`](jekyll/jemoji@b251fd9) Update gemoji requirement from ~> 3.0 to >= 3, < 5 & test with both major ver... * [`663823a`](jekyll/jemoji@663823a) Update history to reflect merge of [#130](https://github-redirect.dependabot.com/jekyll/jemoji/issues/130) \[ci skip\] * [`88f650c`](jekyll/jemoji@88f650c) Update rake requirement from ~> 12.0 to ~> 13.0 ([#130](https://github-redirect.dependabot.com/jekyll/jemoji/issues/130)) * [`d69cb8c`](jekyll/jemoji@d69cb8c) Update history to reflect merge of [#134](https://github-redirect.dependabot.com/jekyll/jemoji/issues/134) \[ci skip\] * [`e0e5701`](jekyll/jemoji@e0e5701) Upgrade Rubocop target version to 2.7 ([#134](https://github-redirect.dependabot.com/jekyll/jemoji/issues/134)) * [`e01a128`](jekyll/jemoji@e01a128) Update history to reflect merge of [#133](https://github-redirect.dependabot.com/jekyll/jemoji/issues/133) \[ci skip\] * [`064f142`](jekyll/jemoji@064f142) Bump actions/checkout from 2 to 3 ([#133](https://github-redirect.dependabot.com/jekyll/jemoji/issues/133)) * Additional commits viewable in [compare view](jekyll/jemoji@v0.12.0...v0.13.0)
No description provided.