add method JavaClass.getTransitiveDependenciesFromSelf #401

hankem · 2020-07-15T11:57:21Z

Instead of the initial getTransitiveDependenciesFromSelfWithinPackage(String packageNamePrefix), I now suggest the simpler API:

    /**
     * Returns the transitive closure of all dependencies originating from this class, i.e. its direct dependencies
     * and the dependencies from all imported target classes.
     * @return all transitive dependencies (including direct dependencies) from this class
     * @see #getDirectDependenciesFromSelf()
     */
    @PublicAPI(usage = ACCESS)
    public Set<Dependency> getTransitiveDependenciesFromSelf() {
        return JavaClassTransitiveDependencies.findTransitiveDependenciesFrom(this);
    }

Signed-off-by: Manfred Hanke Manfred.Hanke@tngtech.com

archunit/src/main/java/com/tngtech/archunit/core/domain/JavaClassTransitiveDependencies.java

archunit/src/test/java/com/tngtech/archunit/core/domain/JavaClassTest.java

archunit/src/main/java/com/tngtech/archunit/core/domain/JavaClass.java

archunit/src/test/java/com/tngtech/archunit/core/domain/JavaClassTest.java

archunit/src/test/java/com/tngtech/archunit/testutil/assertion/DependenciesAssertion.java

...unit/src/test/java/com/tngtech/archunit/core/domain/JavaClassTransitiveDependenciesTest.java

archunit/src/main/java/com/tngtech/archunit/core/domain/JavaClass.java

codecholeric · 2020-09-06T11:32:32Z

Also compare #253?

So far, if a user would call `JavaClass.getDirectDependency{From/To}Self()` on a class that was not directly imported (e.g. a class that was not present in the original import, but accessed by a class from that import) it would cause a NPE. While we do want to cut the class graph at that point (i.e. not further track dependencies for classes that are not part of the import), we do not want this exceptional behavior. This change fixes the behavior and sets empty dependencies for all non-directly imported classes, be it classes that have been resolved from the classpath later on, or stub classes, because further resolution has been turned off. Resolves: #397 Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>

This method reports whether the class is completed from the ImportContext. Take an import of package `com.foo`, where some class `com.foo.Foo` accesses another class `com.bar.Bar`, then `Foo` would be `isFullyImported() == true`, because it was explicitly covered by the package to be imported, but `Bar` would have `isFullyImported() == false`, because it was not covered by the original package. This method is useful, because it has strong implications, whether the class is fully imported or not. For example only a fully imported classes has its dependencies imported, a class that was just imported as a dependency of a fully imported class will have its dependencies cut off to avoid uncontrollably huge imports. Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>

Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>

hankem commented Jul 15, 2020

View reviewed changes

archunit/src/main/java/com/tngtech/archunit/core/domain/JavaClassTransitiveDependencies.java Outdated Show resolved Hide resolved

hankem requested a review from codecholeric July 15, 2020 15:36

hankem marked this pull request as draft July 15, 2020 15:49

hankem marked this pull request as ready for review July 15, 2020 17:20

hankem commented Aug 4, 2020

View reviewed changes

archunit/src/main/java/com/tngtech/archunit/core/domain/JavaClassTransitiveDependencies.java Outdated Show resolved Hide resolved