Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running of individual test methods via Gradle in conjunction with junit-vintage-runner #135

Merged
merged 1 commit into from Mar 13, 2022

Conversation

tngwoerleij
Copy link
Contributor

Overview

Gradle creates org.junit.vintage.engine.descriptor.RunnerTestDescriptor.
ExcludeDescriptionFilters when running individual test methods. The
filter description starts with "exclude " and for those filters, the
request needs to be forwarded to the original filter.shouldRun(...),
as otherwise the DataProvider would run this test even if it should not.


I hereby agree to the terms of the JUnit dataprovider Contributor License Agreement.


Definition of Done

  • There are no TODOs left in the code
  • Method preconditions are checked and documented in the method's Javadoc
  • Change is covered by automated tests (unit and/or integration tests)
  • Build has passed

…th junit-vintage-runner

Gradle creates org.junit.vintage.engine.descriptor.RunnerTestDescriptor.
ExcludeDescriptionFilters when running individual test methods. The
filter description starts with "exclude " and for those filters, the
request needs to be forwarded to the original `filter.shouldRun(...)`,
as otherwise the DataProvider would run this test even if it should not.

Signed-off-by: Jonas Woerlein <jonas.woerlein@tngtech.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.628% when pulling 429efbd on tngwoerleij:exclude-filter-compatibility into 040538c on TNG:main.

@tngwoerleij tngwoerleij marked this pull request as ready for review March 11, 2022 13:46
@aaschmid aaschmid self-requested a review March 11, 2022 17:34
@aaschmid aaschmid merged commit 094381d into TNG:main Mar 13, 2022
@aaschmid aaschmid added this to the v2.9 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants