Added support for disabling /auth context path. Resolves #126 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: TNG#126 Signed-off-by: kilmajster <lukasz.createam@gmail.com>
kilmajster
changed the title
kilmajster
changed the title
ostrya
requested changes
Jun 6, 2023
mock/src/main/java/com/tngtech/keycloakmock/impl/UrlConfiguration.java
Outdated
Show resolved
Hide resolved
mock/src/test/java/com/tngtech/keycloakmock/impl/UrlConfigurationTest.java
Outdated
Show resolved
Hide resolved
Issue: TNG#126 Signed-off-by: kilmajster <lukasz.createam@gmail.com>
|
Thanks for the remarks @ostrya, I pushed my updates, please have a look :) |
ostrya
requested changes
Jun 12, 2023
mock/src/main/java/com/tngtech/keycloakmock/impl/UrlConfiguration.java
Outdated
Show resolved
Hide resolved
| @@ -301,6 +301,7 @@ void unexpected_issuer_causes_exception() { | |||
| Builder builder = aTokenConfig(); | |||
| assertThatThrownBy(() -> builder.withSourceToken(TOKEN_WITH_UNEXPECTED_ISSUER_URL)) | |||
| .isInstanceOf(IllegalArgumentException.class) | |||
| .hasMessageContaining("did not conform to the expected format"); | |||
| .hasMessageContaining("did not conform to the expected format") | |||
| .hasMessageContaining("'http[s]://$HOSTNAME[:port][:contextPath]/realms/$REALM'"); | |||
There was a problem hiding this comment.
The colon in front of port was not meant as an indicator for parameter replacement but as part of the string, e.g. ":8080". Thus, I'd prefix the context path with a slash instead. To make it more clear, I think we can also use the same variable replacement syntax as for the hostname and the realm:
Suggested change
| .hasMessageContaining("'http[s]://$HOSTNAME[:port][:contextPath]/realms/$REALM'"); | |
| .hasMessageContaining("'http[s]://$HOSTNAME[:$PORT][/$CONTEXT_PATH]/realms/$REALM'"); |
There was a problem hiding this comment.
Thanks for the explanation, now this format makes more sense.
Signed-off-by: Kai Helbig <kai.helbig@tngtech.com>
Signed-off-by: Kai Helbig <kai.helbig@tngtech.com>
ostrya
approved these changes
Jun 12, 2023
|
I can see you already applied those suggestions, that's great! So I guess it's good to go now? 😄 |
|
Yes, just forgot to click merge because I wanted to wait for the checks to get green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've added support for disabling or overriding
/authcontext path so that mock can be used with Keycloak 18.0.0+