Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support emptyOn for multi-params #27

Closed
Airblader opened this issue Dec 21, 2018 · 0 comments · Fixed by #105
Closed

Support emptyOn for multi-params #27

Airblader opened this issue Dec 21, 2018 · 0 comments · Fixed by #105
Labels
Comp: Core Core functionality of ngqp Priority: Medium Users can work without this for now, but this should be fixed soon-ish Status: Discussion We're not yet sure whether or how to implement this feature Type: Feature If you want to add something that doesn't exist yet

Comments

@Airblader
Copy link
Collaborator

Perhaps requires a separate mechanism / refactoring since currently emptyOn is evaluated in the serializer, which is invoked per-value.
@Airblader Airblader added the Type: Feature If you want to add something that doesn't exist yet label Dec 21, 2018
@Airblader Airblader mentioned this issue Dec 22, 2018
Closed
@Airblader Airblader added Status: Discussion We're not yet sure whether or how to implement this feature Comp: Core Core functionality of ngqp Priority: Medium Users can work without this for now, but this should be fixed soon-ish labels Dec 31, 2018
Airblader added a commit that referenced this issue Mar 3, 2019
@Airblader
fix(core): Improve typing and support emptyOn for multi:true
8202c83 
This change improves the type safety by not misinterpreting an
array-valued parameter as a multi: true parameter. We also introduce a new
MultiQueryParam type as a shortcut.

As a side effect, we move the evaluation of (de-)serializing entirely to
the service and can thus now support emptyOn for multi: true parameters.

fixes #92
fixes #27

Signed-off-by: Ingo Bürk <ingo.buerk@tngtech.com>
@Airblader Airblader mentioned this issue Mar 3, 2019
Closed
3 tasks
Airblader added a commit that referenced this issue Mar 8, 2019
@Airblader
fix(core): Improve typing and support emptyOn for multi:true
521010c 
This change improves the type safety by not misinterpreting an
array-valued parameter as a multi: true parameter.

As a side effect we can now support emptyOn for multi: true parameters.

fixes #92
fixes #27

Signed-off-by: Ingo Bürk <ingo.buerk@tngtech.com>
@Airblader Airblader mentioned this issue Mar 8, 2019
Merged
3 tasks
Airblader added a commit that referenced this issue Mar 8, 2019
@Airblader
fix(core): Improve typing and support emptyOn for multi:true
7463fa3 
This change improves the type safety by not misinterpreting an
array-valued parameter as a multi: true parameter.

As a side effect we can now support emptyOn for multi: true parameters.

fixes #92
fixes #27

Signed-off-by: Ingo Bürk <ingo.buerk@tngtech.com>
Airblader added a commit that referenced this issue Mar 8, 2019
@Airblader
fix(core): Improve typing and support emptyOn for multi:true
32a5a05 
This change improves the type safety by not misinterpreting an
array-valued parameter as a multi: true parameter.

As a side effect we can now support emptyOn for multi: true parameters.

fixes #92
fixes #27

Signed-off-by: Ingo Bürk <ingo.buerk@tngtech.com>
Airblader added a commit that referenced this issue Mar 8, 2019
@Airblader
fix(core): Improve typing and support emptyOn for multi:true
0e28c35 
This change improves the type safety by not misinterpreting an
array-valued parameter as a multi: true parameter.

As a side effect we can now support emptyOn for multi: true parameters.

fixes #92
fixes #27

Signed-off-by: Ingo Bürk <ingo.buerk@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Comp: Core Core functionality of ngqp Priority: Medium Users can work without this for now, but this should be fixed soon-ish Status: Discussion We're not yet sure whether or how to implement this feature Type: Feature If you want to add something that doesn't exist yet
Projects
None yet
Milestone
No milestone
1 participant
@Airblader