Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔬 Load tidx for callbacks from memory #197

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

tolauwae
Copy link
Member

No description provided.

@tolauwae tolauwae added the experimental Experimental feature/branch label Jul 12, 2023
@carllocos
Copy link
Contributor

By any chance is this PR meant to solve an asc compilation issue related to callbacks?

In my case, I have an Assemblyscript application for which the asc compiler generates a tidx out of range

if (tidx < 0 || m->table.size < tidx) {

The same issue also happens on the MCU.

If not, I'll create a separate issue and I will fix the issue there via another PR.

@tolauwae
Copy link
Member Author

Yes. This has been a known issue for a year, and I finally got round to fixing it.
This PR is not ready to be merged.

@tolauwae
Copy link
Member Author

This has been broken since #73, but the behaviour/reason for the failure has changed since.

@tolauwae tolauwae linked an issue Jul 13, 2023 that may be closed by this pull request
@tolauwae tolauwae linked an issue Jul 13, 2023 that may be closed by this pull request
@carllocos
Copy link
Contributor

I confirm what you describe in issue #73 is what I have been experiencing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Experimental feature/branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix callbacks for AS AssemblyScript example optimized version fails
2 participants