Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of multiqc report generation for the V1 report #221

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Mxrcon
Copy link
Collaborator

@Mxrcon Mxrcon commented Aug 29, 2024

👋 Hey there, updating what we discussed on #99 regardging the V1 report, I came here to share the first successful run for the V1 accommodating QC report from all samples and a heatmap from the SNP distances.

I'd like to hear your opinion about those changes and how it can be improved for better user experience.

Here s an attachment with the report generated by the pipeline.

The overall changes resume on two steps:

  1. Organize channels for file imporation by multiqc
  2. Add multiqc config file

Kindly,
Davi

@Mxrcon Mxrcon requested a review from abhi18av August 29, 2024 13:19
@Mxrcon Mxrcon changed the base branch from master to develop August 29, 2024 13:31
@abhi18av
Copy link
Member

Hi @Mxrcon , I tried to test it locally and it fails with the following message

image

@Mxrcon
Copy link
Collaborator Author

Mxrcon commented Aug 29, 2024

Hi @Mxrcon , I tried to test it locally and it fails with the following message
image

Sorry @abhi18av, rookie mistake i forgot to push the config yaml

@abhi18av abhi18av linked an issue Aug 30, 2024 that may be closed by this pull request
@abhi18av
Copy link
Member

Thanks for the quickfix @Mxrcon - it is starting to look good.

I have 2 suggestions overall within the scope of multiqc-v1

  1. Allow the multiqc report to be generated even with skip_merge_analysis option enabled for the use-cases where the users might only want to do quick QC on the sequences.

  2. Add a python-script to massage the data being staged into the multiqc process, please look at the comments in the screenshot below

image

@abhi18av abhi18av marked this pull request as draft August 30, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish a condensed MultiQC report with the relevant statistics
2 participants