Fix missing close-brace in PostgreSQL XML Connect Pool option #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abondvt89
approved these changes
Mar 22, 2024
jamiere-msft
approved these changes
Mar 22, 2024
|
Merging after reviews and approval of the three members of the code maintenance team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Issue #681 by modifying lines that are deleted so that final close-brace remains when XML connect pool option is selected.
Note that as mentioned in the issue PostgreSQL stored procedures are not supported with prepared statements and therefore this option will always default to functions and will error if trying to use stored procedures.