implement improved node spacing zooming #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waxlamp
requested changes
Sep 9, 2019
There was a problem hiding this comment.
The slider works perfectly, but the mousewheel interaction seems a bit off. The map seems to drift a bit on each wheel event, such that the center of the transform moves away from where the mouse is.
Can you also add something to the README about the ctrl-mousewheel interaction?
|
the shift could be because of some numeric rounding errors and if you don't hit the center perfectly the error adds up |
|
Thanks for looking into it, and for giving me a tour of the code. David Manthey is away from the office right now, so let's just merge this and fix the mouse interaction later. |
waxlamp
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base on #88
closes #86 and closes #85
when changing the node size change the center of the map to the scaled old center. (either center of the map or the position under the mouse)