Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eli] remove deprecated benchmark #23

Merged
merged 1 commit into from
Jan 9, 2022

Conversation

Stefan-Dienst
Copy link
Collaborator

Remove old scripts to avoid confusion, see #22.

@Wentzell
Copy link
Member

Wentzell commented Jan 5, 2022

Which other implementation was this benchmark comparing against?

@Stefan-Dienst
Copy link
Collaborator Author

Stefan-Dienst commented Jan 6, 2022

My first personal implementation without Triqs, which was never public.

@Wentzell
Copy link
Member

Wentzell commented Jan 6, 2022

Ok. Would it be much effort to fix the benchmark as it was previously working?
These comparisons between different implementations are generally useful to keep around.

@Stefan-Dienst
Copy link
Collaborator Author

I generally agree, but in this case it won't be useful as this implementation was still in early testing stage and contained minor errors, which have then be fixed in the tprf implementation.

@Wentzell
Copy link
Member

Wentzell commented Jan 6, 2022

I see. You can go ahead with the merge then. This commit should also be applied to unstable I assume?

@Stefan-Dienst
Copy link
Collaborator Author

Yes, it should.

@Stefan-Dienst Stefan-Dienst merged commit 836af63 into 3.0.x Jan 9, 2022
@Stefan-Dienst Stefan-Dienst deleted the 3.0.x_remove_deprecated_benchmark branch January 9, 2022 16:43
@Wentzell
Copy link
Member

Could you please create the corresponding PR also for unstable? It seems your commit cannot simply be cherry-picked on unstable as some files have been moved.

@Wentzell
Copy link
Member

@StefanKaeser

@Wentzell
Copy link
Member

You can of course also just directly push this to unstable.

@Stefan-Dienst
Copy link
Collaborator Author

I have directly pushed this change to unstable.

@Stefan-Dienst Stefan-Dienst restored the 3.0.x_remove_deprecated_benchmark branch February 26, 2022 14:46
@Stefan-Dienst Stefan-Dienst deleted the 3.0.x_remove_deprecated_benchmark branch February 26, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem executing benchmark/eliashberg/tprf_implementation.py in 3.0.0 version
2 participants