-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eli] remove deprecated benchmark #23
Conversation
Which other implementation was this benchmark comparing against? |
My first personal implementation without Triqs, which was never public. |
Ok. Would it be much effort to fix the benchmark as it was previously working? |
I generally agree, but in this case it won't be useful as this implementation was still in early testing stage and contained minor errors, which have then be fixed in the tprf implementation. |
I see. You can go ahead with the merge then. This commit should also be applied to unstable I assume? |
Yes, it should. |
Could you please create the corresponding PR also for unstable? It seems your commit cannot simply be |
@StefanKaeser |
You can of course also just directly push this to unstable. |
I have directly pushed this change to unstable. |
Remove old scripts to avoid confusion, see #22.