Fixed a number of out of bounds accesses. #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visual Studio's static code analyser found a number of out of bounds array accesses. This commit fixes a number of them as well as a few other problems the analyser brought up. This also fixes TTimo#1 in the issue tracker.
|
As we discussed in irc some time ago, this seems a bit dangerous to apply with no bugs to explicitly fix and no real way to make sure there are no regressions from this. I am tempted to push those in with the next GtkRadiant release cycle though (1.6.5), and ask folks to compile a few of their more complex maps with the new compiler, report if there are new problems. |
TTimo
added a commit
that referenced
this pull request
Mar 8, 2015
Fixed a number of out of bounds accesses.
|
Trying to get a new release cycle under way .. might as well pull this in. Thanks for submitting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Studio's static code analyser found a number of out of bounds array accesses. This commit fixes a number of them as well as a few other problems the analyser brought up.
This also fixes #1 in the issue tracker.