Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix q3map2 pak sorting #615

Merged
merged 1 commit into from
Apr 21, 2018
Merged

Fix q3map2 pak sorting #615

merged 1 commit into from
Apr 21, 2018

Conversation

isRyven
Copy link
Contributor

@isRyven isRyven commented Mar 24, 2018

  • Copied over sorting function from radiant's vfs
  • Adapted directory initialization code to run sorting

Tested on map, works good so far. No optimization was done to reduce number of iterations, but i don't want to break anything.

closes #614

@isRyven isRyven changed the title fix q3map2 pak sorting Fix q3map2 pak sorting Mar 24, 2018

g_free( dirlist );
g_free(name);
dirlist = g_slist_remove(cur, name);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a little safer to free after the list remove, but that should be ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops 😁 thanks for fixing that!

@TTimo TTimo merged commit 1219ad4 into TTimo:master Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

q3map2 vfs does not reverse pak list upon dir initialization
2 participants