Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract useful info from cypher remove, set, unwind #370

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,12 @@

package org.grapheco.lynx.logical

import org.opencypher.v9_0.ast.Remove
import org.opencypher.v9_0.ast.RemoveItem

/**
*@description:
*/
case class LogicalRemove(r: Remove)(val in: Option[LogicalNode]) extends LogicalNode {
case class LogicalRemove(removeItems: Seq[RemoveItem])(val in: Option[LogicalNode])
extends LogicalNode {
override val children: Seq[LogicalNode] = in.toSeq
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,12 @@

package org.grapheco.lynx.logical

import org.opencypher.v9_0.ast.SetClause
import org.opencypher.v9_0.ast.SetItem

/**
*@description:
*/
case class LogicalSetClause(d: SetClause)(val in: Option[LogicalNode]) extends LogicalNode {
case class LogicalSetClause(setItems: Seq[SetItem])(val in: Option[LogicalNode])
extends LogicalNode {
override val children: Seq[LogicalNode] = in.toSeq
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,16 @@

package org.grapheco.lynx.logical

import org.opencypher.v9_0.ast.Unwind
import org.grapheco.lynx.expression.LynxVariable
import org.opencypher.v9_0.expressions.Expression

/**
*@description:
*/
case class LogicalUnwind(u: Unwind)(val in: Option[LogicalNode]) extends LogicalNode {
case class LogicalUnwind(
variable: LynxVariable,
expression: Expression
)(val in: Option[LogicalNode])
extends LogicalNode {
override val children: Seq[LogicalNode] = in.toSeq
}
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ case class LogicalRemoveTranslator(r: Remove) extends LogicalNodeTranslator {
in: Option[LogicalNode]
)(implicit plannerContext: LogicalPlannerContext
): LogicalNode =
LogicalRemove(r)(in)
LogicalRemove(r.items)(in)
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@

package org.grapheco.lynx.logical.translator

import org.grapheco.lynx.expression.LynxVariable
import org.grapheco.lynx.expression.utils.ConvertExpressionToLynxExpression
import org.grapheco.lynx.logical.plan.LogicalPlannerContext
import org.grapheco.lynx.logical.{LogicalNode, LogicalSetClause}
import org.opencypher.v9_0.ast.SetClause
import org.opencypher.v9_0.ast.{SetClause, SetExactPropertiesFromMapItem, SetIncludingPropertiesFromMapItem, SetPropertyItem}

/**
*@description:
Expand All @@ -22,6 +24,25 @@ case class LogicalSetClauseTranslator(s: SetClause) extends LogicalNodeTranslato
override def translate(
in: Option[LogicalNode]
)(implicit plannerContext: LogicalPlannerContext
): LogicalNode =
LogicalSetClause(s)(in)
): LogicalNode = {
val lynxItems = s.items.map {
case s @ SetPropertyItem(property, expression) =>
SetPropertyItem(property, ConvertExpressionToLynxExpression.convert(expression))(s.position)

// TODO: Convert setClause
case s @ SetExactPropertiesFromMapItem(variable, expression) =>
SetExactPropertiesFromMapItem(
variable,
ConvertExpressionToLynxExpression.convert(expression)
)(s.position)

case s @ SetIncludingPropertiesFromMapItem(variable, expression) =>
SetIncludingPropertiesFromMapItem(
variable,
ConvertExpressionToLynxExpression.convert(expression)
)(s.position)
}

LogicalSetClause(lynxItems)(in)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

package org.grapheco.lynx.logical.translator

import org.grapheco.lynx.expression.LynxVariable
import org.grapheco.lynx.expression.utils.ConvertExpressionToLynxExpression
import org.grapheco.lynx.logical.plan.LogicalPlannerContext
import org.grapheco.lynx.logical.{LogicalNode, LogicalUnwind}
import org.opencypher.v9_0.ast.Unwind
Expand All @@ -22,10 +24,15 @@ case class LogicalUnwindTranslator(u: Unwind) extends LogicalNodeTranslator {
override def translate(
in: Option[LogicalNode]
)(implicit plannerContext: LogicalPlannerContext
): LogicalNode =
): LogicalNode = {
// in match {
// case None => LogicalUnwind(u)(None)
// case Some(left) => LogicalJoin(isSingleMatch = false)(left, LogicalUnwind(u)(in))
// }
LogicalUnwind(u)(in)

LogicalUnwind(
LynxVariable(u.variable.name),
ConvertExpressionToLynxExpression.convert(u.expression)
)(in)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

package org.grapheco.lynx.physical

import org.grapheco.lynx.expression.LynxVariable
import org.grapheco.lynx.physical.plan.PhysicalPlannerContext
import org.grapheco.lynx.{DataFrame, ExecutionContext, LynxType}
import org.grapheco.lynx.types.LynxValue
Expand All @@ -22,8 +23,8 @@ import org.opencypher.v9_0.util.symbols.CTAny
*@description:
*/
case class PhysicalUnwind(
expression: Expression,
variable: Variable
variable: LynxVariable,
expression: Expression
)(implicit val in: Option[PhysicalNode],
val plannerContext: PhysicalPlannerContext)
extends AbstractPhysicalNode {
Expand Down Expand Up @@ -66,5 +67,5 @@ case class PhysicalUnwind(
}

override def withChildren(children0: Seq[PhysicalNode]): PhysicalUnwind =
PhysicalUnwind(expression, variable)(children0.headOption, plannerContext)
PhysicalUnwind(variable, expression)(children0.headOption, plannerContext)
}
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,12 @@ class DefaultPhysicalPlanner(runnerContext: QueryRunnerContext) extends Physical
PhysicalPatternMatchTranslator(patternMatch)(plannerContext).translate(None)
case li @ LogicalCreateIndex(labelName: LabelName, properties: List[PropertyKeyName]) =>
PhysicalCreateIndex(labelName, properties)(plannerContext)
case sc @ LogicalSetClause(d) =>
PhysicalSetClauseTranslator(d.items).translate(sc.in.map(plan(_)))(plannerContext)
case lr @ LogicalRemove(r) =>
PhysicalRemoveTranslator(r.items).translate(lr.in.map(plan(_)))(plannerContext)
case lu @ LogicalUnwind(u) =>
PhysicalUnwindTranslator(u.expression, u.variable)
case sc @ LogicalSetClause(setItems) =>
PhysicalSetClauseTranslator(setItems).translate(sc.in.map(plan(_)))(plannerContext)
case lr @ LogicalRemove(removeItems) =>
PhysicalRemoveTranslator(removeItems).translate(lr.in.map(plan(_)))(plannerContext)
case lu @ LogicalUnwind(variable, expression) =>
PhysicalUnwindTranslator(variable, expression)
.translate(lu.in.map(plan(_)))(plannerContext)
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,20 @@

package org.grapheco.lynx.physical.translator

import org.grapheco.lynx.expression.LynxVariable
import org.grapheco.lynx.physical.plan.PhysicalPlannerContext
import org.grapheco.lynx.physical.{PhysicalNode, PhysicalUnwind}
import org.opencypher.v9_0.expressions.{Expression, Variable}
import org.opencypher.v9_0.expressions.Expression

/**
*@description:
*/
case class PhysicalUnwindTranslator(expression: Expression, variable: Variable)
case class PhysicalUnwindTranslator(variable: LynxVariable, expression: Expression)
extends PhysicalNodeTranslator {
override def translate(
in: Option[PhysicalNode]
)(implicit ppc: PhysicalPlannerContext
): PhysicalNode = {
PhysicalUnwind(expression, variable)(in, ppc)
PhysicalUnwind(variable, expression)(in, ppc)
}
}