Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruff formatting #51

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Ruff formatting #51

merged 5 commits into from
Nov 7, 2023

Conversation

rogerkuou
Copy link
Member

No description provided.

@rogerkuou rogerkuou mentioned this pull request Nov 7, 2023
Closed
25 tasks
@rogerkuou rogerkuou marked this pull request as draft November 7, 2023 14:08
@rogerkuou rogerkuou changed the title Lint test Ruff formatting Nov 7, 2023
@rogerkuou rogerkuou marked this pull request as ready for review November 7, 2023 15:17
@rogerkuou
Copy link
Member Author

Hi @SarahAlidoost , could you please review the Ruff formatting?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

SarahAlidoost
SarahAlidoost reviewed Nov 7, 2023
View reviewed changes
pyproject.toml
source = ["stmtools"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default ruff configuration assumes python 3.8, see target-version here. I suggest adding the same configs here and here to the pyproject.toml.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied the python 3.10 rule and kept others the same

Copy link
Contributor

@SarahAlidoost SarahAlidoost Nov 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As explained here, if you want to use pyproject.toml, you need to pass all the settings because ruff will use this file instead of the default file, ruff does not merge settings across different files. So I suggest adding the same configs mentioned here and here to the pyproject.toml.

SarahAlidoost
SarahAlidoost approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogerkuou awesome 🥳 please see my suggestions. I approved this PR.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@rogerkuou rogerkuou merged commit 959c1ca into main Nov 7, 2023
18 checks passed
@SarahAlidoost SarahAlidoost mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SarahAlidoost SarahAlidoost SarahAlidoost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rogerkuou @SarahAlidoost