-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
34 morton sorting #56
Conversation
Note that for application to an stm, we should still check whether we can specify to mortonorder() the dimensions to sort on. Otherwise, we could temporarily rename lat-lon to Y-X before sorting.
… using pymorton based on pixel coordinates. This should be made a lazily executing function in stm.py
otherwise sticking to main.
Tests: * existence of attribute before evaluation. * correctness of order after sorting manually (integers). * correctness of order after sorting using function (integers). * correctness of order aftre sorting (float values with(out) scaling).
Kudos, SonarCloud Quality Gate passed! |
Hi @vanlankveldthijs, thanks a lot for the implement! I did several change:
To me it's all good to merge. Would you like to give a final check? |
Hi @vanlankveldthijs , I will merge this maybe? |
Added functions to STM for creating order attribute per point (implemented as Morton code).
Commented these functions.
Added several unit tests for these functions.