34 morton sorting #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that for application to an stm, we should still check whether we can specify to mortonorder() the dimensions to sort on. Otherwise, we could temporarily rename lat-lon to Y-X before sorting.
… using pymorton based on pixel coordinates. This should be made a lazily executing function in stm.py
otherwise sticking to main.
Tests: * existence of attribute before evaluation. * correctness of order after sorting manually (integers). * correctness of order after sorting using function (integers). * correctness of order aftre sorting (float values with(out) scaling).
|
Kudos, SonarCloud Quality Gate passed! |
|
Hi @vanlankveldthijs, thanks a lot for the implement! I did several change:
To me it's all good to merge. Would you like to give a final check? |
|
Hi @vanlankveldthijs , I will merge this maybe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functions to STM for creating order attribute per point (implemented as Morton code).
Commented these functions.
Added several unit tests for these functions.