Release/1.3 #202
Release/1.3 #202
Conversation
…update # Conflicts: # Pods/Pods.xcodeproj/project.pbxproj # Pods/Target Support Files/Pods-Campus/Pods-Campus.debug.xcconfig # Pods/Target Support Files/Pods-Campus/Pods-Campus.release.xcconfig # TUM Campus App.xcodeproj/project.pbxproj
# Conflicts: # Pods/Pods.xcodeproj/project.pbxproj # Pods/Target Support Files/Pods-Campus/Pods-Campus-resources.sh # Pods/Target Support Files/Pods-Campus/Pods-Campus.debug.xcconfig # Pods/Target Support Files/Pods-Campus/Pods-Campus.release.xcconfig # TUM Campus App/TumDataManager.swift
# Conflicts: # Pods/Pods.xcodeproj/project.pbxproj
# Conflicts: # Podfile.lock # TUM Campus App.xcodeproj/project.pbxproj # TUM Campus App/CalendarManager.swift # TUM Campus App/Extensions.swift
|
@TG908 Going to more and back makes the navbar in the card view have a large title. Even without text. |
|
@TG908 is there anyway we can open the search results on the same navigation controller |
|
@mathiasquintero I think the search results controller is opened in a whole new ui window. We could use the card table view to display our search results. But I think this should be low priority. |
|
What if we keep a weak reference to the root vc and call push on those? |
I cannot reproduce this
I'll try |
|
Here you go! The text may not be there, but do you see the height difference?
|
|
@mathiasquintero is this the iphone x? |
|
Yes. But can be reproduced on any iphone |
Would work will do a proper implementation tomorrow. |
|
@TG908 looks great now! I think we're done with most of what we wanted to do here. I'd say we are only missing the extra cards you wanted to make for like MVV, Library, Lectures, etc... 😉 Perhaps you can get started on that in a separate branch starting from this one and we can later merge it back. So that we still follow the process |
|
@mathiasquintero I think the new cards and improved ui might take a while, because I'm quite busy. What I still need to do is take a look at the BookRental Card. Otherwise we are good. 😄 Have you looked into the threading issues (race conditions, etc.)? |
|
Fixed Book Rentals we are ready for launch 🚀 . I cannot upload because I don't have the permissions. |
|
@mammuth have you checked this out? |
|
We also have to update the bundle version |
|
The build got stuck on |
| keychainWrapper.writeToKeychain() | ||
| UserDefaults.standard.synchronize() | ||
| } | ||
| // TODO: Refactor use of keychain wrapper |
There was a problem hiding this comment.
| UserDefaults.standard.synchronize() | ||
| } | ||
| // TODO: Refactor use of keychain wrapper | ||
| // TODO: Move this to the manager. This is really the managers job. |
There was a problem hiding this comment.
|
Merging this now! |
Please test this.
Fixes #190
Fixes #179
Fixes #118
Fixes #72
Fixes #109
Starts progress in #43 & #165
Fixes #156
Fixes #90
Fixes #195
Fixes #194
Fixes #121