Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

More View crashes/doesnt display name #118

Closed
tgymnich opened this issue May 4, 2017 · 0 comments
Closed

More View crashes/doesnt display name #118

tgymnich opened this issue May 4, 2017 · 0 comments

Comments

@tgymnich
Copy link
Member

tgymnich commented May 4, 2017

When the user is having a bad internet connection (try Network Link Conditioner edge for example) in the More Table View the users name is not loaded and clicking on the blank card is causing a crash.

var user: User? {
        didSet {
            updateView()
        }
    }

This code tries to update the view when the user is set. When the user is having a bad internet connection the user is set but user.data is not yet set. This will:

  • cause a crash in the time user.data is not yet loaded on clicking the cell
  • cause the name label to never be set since updateViews() is called when user is set not user.data

Related to #70

I was able to fix the crash but the missing name is a bug in the model

@tgymnich tgymnich added this to the 1.2 milestone May 4, 2017
@tgymnich tgymnich changed the title PersonDetailView crashes/doesnt display name More View crashes/doesnt display name May 4, 2017
@mammuth mammuth modified the milestones: 1.2, 1.3 Oct 18, 2017
This was referenced Oct 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants