-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search through subtitles #955
Conversation
Your Testserver will be ready at https://955.test.live.mm.rbg.tum.de in a few minutes. Logins
|
This unbelievably sexy!!!!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how but you read my mind, I was about to suggest that feature next Wednesday!
Works great, Looks great 💯
What's your take on this: Do you think we could already implement a TUM-Live "complete" search using Meili? e.g. for the new start page.
Added some minor request changes.
Definitely a feature I want! But currently not really feasible in my opinion until we have more subtitles. If a user had a search now they would always only find results in the one lecture with subtitles which might be confusing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks ⚡
Motivation and Context
This PR implements searching through the subtitles of an individual stream, allowing students to quickly find a topic in them.
Course-wide search could be a follow up.
Related to #796
Description
This PR adds
Steps for Testing
Prerequisites:
config.yml
/admin/maintenance
and run the meili export cron jobScreenshots
out.mp4