Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Security Updates #5

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

strobelm
Copy link
Contributor

@strobelm strobelm commented Feb 13, 2024

Hey all,

I've prepared a pull request with some security updates for the meldeplattform. Here's a breakdown of the changes:

  1. Ran npm audit fix: Ensure that we fix any vulnerabilities reported by npm audit.

  2. Deduplicate version strings in Dockerfile and update to latest versions of Go and Alpine: Optimize our Dockerfile by removing duplicate version strings and ensuring we're using the latest versions of Go and Alpine.

  3. Update all Go dependencies recursively: Ensure we're using the latest security patches and bug fixes by updating all dependencies recursively.

Impact

Closes several security vulnerabilities in the go and node packages. No functional changes were done.

How to test

I was running this using podman run --privileged -v ./files:/files -p 8080:8080 , the page seems to load fine. One thing I noticed using this local setup is that I actually cannot really select an issue. Any input on this?

image

@joschahenningsen
Copy link
Sponsor Member

the page seems to load fine. One thing I noticed using this local setup is that I actually cannot really select an issue. Any input on this?

Can you verify that the config.yaml is mounted next to the executable within the container? Any reason you use podman over Docker, considering Docker is well maintained and documented for this application?

go.mod Outdated Show resolved Hide resolved
@joschahenningsen
Copy link
Sponsor Member

One thing I noticed using this local setup is that I actually cannot really select an issue. Any input on this?

When running this locally, the database will initially be empty and therefore there are no topics to report to. In order to create some you have to log in and create one. This could be a little tricky tho because you don't have the idp certificate locally... Do you want me to build a simple debug mode that allows local admin login in development environments for testing?

@strobelm
Copy link
Contributor Author

One thing I noticed using this local setup is that I actually cannot really select an issue. Any input on this?

When running this locally, the database will initially be empty and therefore there are no topics to report to. In order to create some you have to log in and create one. This could be a little tricky tho because you don't have the idp certificate locally... Do you want me to build a simple debug mode that allows local admin login in development environments for testing?

Thanks for the offer, but I think I can manage 🙂. One more thing I could use your help: I do not have the rights to push the merge button 😄

@joschahenningsen joschahenningsen merged commit 0f2dd25 into TUM-Dev:main Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants