AEM6 #53
Merged
AEM6 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cculb, @jbyrnessnip, @jbornemann, @sagarsane, @masroormohammed, @sikarwarvimal Please review. |
| @@ -70,6 +59,7 @@ jar.manifest { | |||
| instruction 'Import-Package', 'org.springframework.aop.scope; version="[3.1,4.0)"' | |||
| instruction 'Import-Package', 'org.springframework.scheduling.concurrent; version="[3.1,4.0)"' | |||
| instruction 'Import-Package', "org.aopalliance.aop;version=1.0.0" | |||
| instruction 'Import-Package', "sun.misc" | |||
There was a problem hiding this comment.
I am not sure if sun.misc is required by our bundle. I thought sun.misc is only required by groovy's json package ?
There was a problem hiding this comment.
It's a required runtime dependency. It's optional for Groovy because it may or may not be called: Grabbit will be calling it.
|
Updated the metadata to resolve the "upload/install" disconnect. |
|
I tested the branch, the build is much happier now with the upload/install fix. Everything works, was able to grab content successfully. |
|
+1 code review and testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings in updated libraries and VLT metadata.
TWCable/cq-gradle-plugin#24 is currently outstanding.