Fix #15: Restrict lint tasks to root project only

quality/src/main/kotlin/net/twisterrob/gradle/quality/QualityPlugin.kt

@@ -23,10 +23,10 @@ class QualityPlugin : BaseExposedPlugin() {
 		if (project.rootProject == project) {
 			project.tasks.register("violationReportConsole", ValidateViolationsTask::class.java)
 			project.tasks.register("violationReportHtml", HtmlReportTask::class.java)
-		}
-		project.afterEvaluate {
-			if (project.tasks.findByName("lint") == null) {
-				project.tasks.register("lint", GlobalLintGlobalFinalizerTask::class.java)
+			project.afterEvaluate {
+				if (project.tasks.findByName("lint") == null) {
+					project.tasks.register("lint", GlobalLintGlobalFinalizerTask::class.java)
+				}
 			}
 		}
 	}

quality/src/test/kotlin/net/twisterrob/gradle/quality/QualityPluginTest.kt

@@ -1,7 +1,9 @@
 package net.twisterrob.gradle.quality
 
+import net.twisterrob.gradle.quality.tasks.GlobalLintGlobalFinalizerTask
 import net.twisterrob.gradle.test.GradleRunnerRule
 import net.twisterrob.gradle.test.assertHasOutputLine
+import net.twisterrob.gradle.test.assertNoOutputLine
 import org.gradle.testkit.runner.BuildResult
 import org.gradle.testkit.runner.TaskOutcome.SUCCESS
 import org.hamcrest.Matchers.containsString
@@ -17,7 +19,7 @@ class QualityPluginTest {
 
 	@Rule @JvmField val gradle = GradleRunnerRule()
 
-	@Test fun `apply report violationReportConsole only on root project`() {
+	@Test fun `apply violationReportConsole only on root project`() {
 		`given`@
 		@Language("gradle")
 		val script = """
@@ -44,7 +46,7 @@ class QualityPluginTest {
 		)
 	}
 
-	@Test fun `apply report violationReportHtml only on root project`() {
+	@Test fun `apply violationReportHtml only on root project`() {
 		`given`@
 		@Language("gradle")
 		val script = """
@@ -70,4 +72,53 @@ class QualityPluginTest {
 			"Configuring task ':violationReportHtml'"
 		)
 	}
+
+	@Test fun `apply lint only on root project`() {
+		`given`@
+		@Language("gradle")
+		val script = """
+			allprojects {
+				apply plugin: 'net.twisterrob.quality'
+				tasks.withType(${GlobalLintGlobalFinalizerTask::class.qualifiedName}) {
+					println("Added " + it)
+				}
+			}
+		""".trimIndent()
+
+		val result: BuildResult
+		`when`@
+		result = gradle
+			.basedOn("android-all_kinds")
+			.run(script, "lint")
+			.build()
+
+		`then`@
+		assertEquals(SUCCESS, result.task(":lint")!!.outcome)
+		result.assertHasOutputLine("one task added for finalizer", "Added task ':lint'")
+		result.assertNoOutputLine("no other tasks added as finalizer", """Added task ':(.+?):lint'""".toRegex())
+	}
+
+	@Test fun `apply lint only when Android does not add lint task`() {
+		`given`@
+		@Language("gradle")
+		val script = """
+			allprojects {
+				apply plugin: 'net.twisterrob.quality'
+				tasks.withType(${GlobalLintGlobalFinalizerTask::class.qualifiedName}) {
+					println("Added " + it)
+				}
+			}
+		""".trimIndent()
+
+		val result: BuildResult
+		`when`@
+		result = gradle
+			.basedOn("android-root_app")
+			.run(script, "lint")
+			.build()
+
+		`then`@
+		assertEquals(SUCCESS, result.task(":lint")!!.outcome)
+		result.assertNoOutputLine("no tasks added as finalizer", """Added task '(.*?):lint'""".toRegex())
+	}
 }

test/src/test/resources/android-all_kinds/build.gradle

@@ -10,12 +10,11 @@ buildscript {
 
 allprojects {
 	repositories {
+		google() // for aapt2 internal binary
 		jcenter() // quality plugin needs to be downloaded in test
 	}
-	plugins.all {
-		if (it instanceof com.android.build.gradle.BasePlugin) {
-			// BEWARE: InstantAppExtension overrides compileSdkVersion and hard-codes it (3.0.1 to 26, 3.2.x to 27)
-			android.compileSdkVersion 27
-		}
+	plugins.withType(com.android.build.gradle.BasePlugin) {
+		// BEWARE: InstantAppExtension overrides compileSdkVersion and hard-codes it (3.0.1 to 26, 3.2.x to 27)
+		android.compileSdkVersion 27
 	}
 }