AndroidX YOLO upgrade #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
TWiStErRob
commented
Mar 16, 2023
•
TWiStErRob
commented
- Fixes Missing theme setup for NavigationView #156 in d407282
…with a static method getLocalBroadcastManager where the deprecation can be hidden for now.
Originally it was black, now it's using the primary color. The reason is that between material 1.2.1 and 1.8.0, the NavigationView constructor has changed. In particular textAppearanceSet was set to true, which didn't set up the itemTextColor, even though the textAppearance was 0. This was because the `app:itemTextAppearance="?attr/titleTextAppearance"` line in the XML was resolving to nothing, because the attribute is not meant to be used outside of a Toolbar.
This reverts commit ddea4aa.
This was referenced Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.