Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reload config on change rather than restart #119

Open
TWilkin opened this issue Mar 2, 2022 · 1 comment · Fixed by #515, #520 or #521
Open

Reload config on change rather than restart #119

TWilkin opened this issue Mar 2, 2022 · 1 comment · Fixed by #515, #520 or #521
Labels
api Relating to the API service energenie-controller Relating to the energenie controller service enhancement New feature or request harmony-controller Relating to the harmony controller service lifx-controller Relating to the LIFX controller service network-controller Relating to the network controller service scheduler Relating to the scheduler service snapcast-controller Relating to the Snapcast controller virtual-controller Relating to the virtual controller service voice-assistant Relating to the voice-assistant service zigbee-controller Relating to the ZigBee controller service
Milestone
High Availability

Comments

@TWilkin
Copy link
Owner

TWilkin commented Mar 2, 2022

  • Update ConfigRetriever to allow registering of config reload listeners.
  • Add mixin/interface for configuration reload.
  • Add reload method to services that use config.
  • ZigBee devices also need to unregister their listeners for reloading.
@TWilkin TWilkin added enhancement New feature or request energenie-controller Relating to the energenie controller service zigbee-controller Relating to the ZigBee controller service virtual-controller Relating to the virtual controller service voice-assistant Relating to the voice-assistant service scheduler Relating to the scheduler service harmony-controller Relating to the harmony controller service lifx-controller Relating to the LIFX controller service api Relating to the API service labels Mar 2, 2022
@TWilkin TWilkin added this to the High Availability milestone Jul 6, 2023
@TWilkin TWilkin added node-controller Relating to the node controller service network-controller Relating to the network controller service and removed voice-assistant Relating to the voice-assistant service labels Jul 6, 2023
@TWilkin TWilkin removed the node-controller Relating to the node controller service label Oct 23, 2023
TWilkin added a commit that referenced this issue May 7, 2024
@TWilkin
#119 chore: Bump @powerpi/common to v0.2.0
9b1790c
TWilkin added a commit that referenced this issue May 7, 2024
@TWilkin
#119 feat: Add an option to disable the restart on config change
cb48034
TWilkin added a commit that referenced this issue May 7, 2024
@TWilkin
#119 feat: Add listeners to ConfigRetrieverService
2529ae9
TWilkin added a commit that referenced this issue May 7, 2024
@TWilkin
#119 chore: Move tests to src
9bfcb4a
TWilkin added a commit that referenced this issue May 7, 2024
@TWilkin
#119 tests: Add tests for config change listeners
2124c25
TWilkin added a commit that referenced this issue May 7, 2024
@TWilkin
#119 refactor: Rename the config change listener to be more inline wi…
4bb3531 
…th others
TWilkin added a commit that referenced this issue May 7, 2024
@TWilkin
#119 chore: Increase referenced common API version
3263ea5
TWilkin added a commit that referenced this issue May 7, 2024
@TWilkin
#119 feat: Add the listener to DeviceStateService
416616b
TWilkin added a commit that referenced this issue May 7, 2024
@TWilkin
#119 feat: Add config change listener to SensorStateService
799ccf3
TWilkin added a commit that referenced this issue May 25, 2024
@TWilkin
#119 feat: Add utility function isDefined
92e9573
TWilkin added a commit that referenced this issue May 25, 2024
@TWilkin
#119 feat: Merge the device state with new config onConfigChange
7ee8579
TWilkin added a commit that referenced this issue May 25, 2024
@TWilkin
#119 feat: Update SensorStateService to update onConfigChange
dc5b024
TWilkin added a commit that referenced this issue May 26, 2024
@TWilkin
#119 refactor: Refactor SensorStateService to match DeviceStateService
2f2549b
TWilkin added a commit that referenced this issue May 26, 2024
@TWilkin
#119 refactor: Update ApiSocketService to work as a notifier service
a3e18ce
TWilkin added a commit that referenced this issue May 26, 2024
@TWilkin
#119 tests: Update StateService tests to check notifications are called
d966478
TWilkin added a commit that referenced this issue May 26, 2024
@TWilkin
#119 chore: Bump @powerpi/common-api to v0.1.7
166c406
TWilkin added a commit that referenced this issue May 27, 2024
@TWilkin
#119 fix: Actually disconnect MQTT when force closing the API
4bd8065
TWilkin added a commit that referenced this issue May 27, 2024
@TWilkin
#119 fix: Fix issue where topic regex only replaced first +
68affb4
TWilkin added a commit that referenced this issue May 27, 2024
@TWilkin
#119 tests: Fix test after topic change
b990d18
TWilkin added a commit that referenced this issue May 27, 2024
@TWilkin
#119 chore: Remove console.log
cdb126b
@TWilkin TWilkin mentioned this issue May 27, 2024
Merged
TWilkin added a commit that referenced this issue Jun 11, 2024
@TWilkin
#119 fix: Update type in DeviceHandler
903e331
TWilkin added a commit that referenced this issue Jun 11, 2024
@TWilkin
#119 feat: Merge the initial config with defaults
fae9a45
TWilkin added a commit that referenced this issue Jun 11, 2024
@TWilkin
#119 docs: Improve comments
949af63
TWilkin added a commit that referenced this issue Jun 11, 2024
@TWilkin
#119 feat: UserService also needs to respond to config changes
d22d818
TWilkin added a commit that referenced this issue Jun 13, 2024
@TWilkin
Merge pull request #515 from TWilkin/119.api-config
7978f87 
#119 feat(api): Support loading new config rather than restarting
@TWilkin TWilkin linked a pull request Jun 13, 2024 that will close this issue
#119 feat(api): Support loading new config rather than restarting #515
Merged
TWilkin added a commit that referenced this issue Jun 13, 2024
@TWilkin
#119 fix: Missed exports from common-api
43911b0
TWilkin added a commit that referenced this issue Jun 13, 2024
@TWilkin
#119 feat: Invalidate sensors onConfigChange
abd76a5
TWilkin added a commit that referenced this issue Jun 13, 2024
@TWilkin
#119 feat: Invalidate devices onConfigChange
df64ebf
TWilkin added a commit that referenced this issue Jun 13, 2024
@TWilkin
#119 feat: Invalidate floorplan onConfigChange
73384a5
TWilkin added a commit that referenced this issue Jun 13, 2024
@TWilkin
#119 refactor: Make the QueryKeyFactory methods readonly
8cf13d8
TWilkin added a commit that referenced this issue Jun 13, 2024
@TWilkin
#119 test: Add test for useGetFloorplan
8ae79bf
TWilkin added a commit that referenced this issue Jun 13, 2024
@TWilkin
#119 refactor: Rename these hooks so the files match the export
01dda80
TWilkin added a commit that referenced this issue Jun 13, 2024
@TWilkin
#119 tests: Add tests for useGetSensors
4f683a1
TWilkin added a commit that referenced this issue Jun 13, 2024
@TWilkin
#119 tests: Add tests for useGetDevices
12432fe
TWilkin added a commit that referenced this issue Jun 13, 2024
@TWilkin
#119 feat: Need to make the callback async
b931ef8
TWilkin added a commit that referenced this issue Jun 13, 2024
@TWilkin
#119 tests: Need to wrap the listener calls in act
00ae5f1
TWilkin added a commit that referenced this issue Jun 13, 2024
@TWilkin
Merge pull request #520 from TWilkin/119.ui-config
19eda22 
#119 feat(ui): Refresh devices, sensors and floorplan when config changes
@TWilkin TWilkin linked a pull request Jun 13, 2024 that will close this issue
#119 feat(ui): Refresh devices, sensors and floorplan when config changes #520
Merged
TWilkin added a commit that referenced this issue Jun 13, 2024
@TWilkin
#119 feat: Remove the restart option
03364c1
TWilkin added a commit that referenced this issue Jun 13, 2024
@TWilkin
Merge pull request #521 from TWilkin/119.voice-assistant-config
2c715b7 
#119 feat: Upgrade voice-assistant so it won't restart when config changes
@TWilkin TWilkin linked a pull request Jun 13, 2024 that will close this issue
#119 feat: Upgrade voice-assistant so it won't restart when config changes #521
Merged
@TWilkin
Copy link
Owner Author

TWilkin commented Jun 13, 2024

All Javascript services upgraded!

@TWilkin TWilkin added snapcast-controller Relating to the Snapcast controller voice-assistant Relating to the voice-assistant service labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Relating to the API service energenie-controller Relating to the energenie controller service enhancement New feature or request harmony-controller Relating to the harmony controller service lifx-controller Relating to the LIFX controller service network-controller Relating to the network controller service scheduler Relating to the scheduler service snapcast-controller Relating to the Snapcast controller virtual-controller Relating to the virtual controller service voice-assistant Relating to the voice-assistant service zigbee-controller Relating to the ZigBee controller service
Projects
None yet
Milestone
High Availability
1 participant
@TWilkin