Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#119 feat: Upgrade voice-assistant so it won't restart when config changes #521

Merged
merged 2 commits into from
Jun 13, 2024
Merged

#119 feat: Upgrade voice-assistant so it won't restart when config changes #521

merged 2 commits into from
Jun 13, 2024

Conversation

TWilkin
Copy link
Owner

@TWilkin TWilkin commented Jun 13, 2024

  • As this is the last Javascript service, remove the restart option entirely.
  • voice-assistant goes directly to ConfigService for device list so there's no direct changes needed.

@TWilkin TWilkin added enhancement New feature or request voice-assistant Relating to the voice-assistant service labels Jun 13, 2024
@TWilkin TWilkin merged commit 2c715b7 into main Jun 13, 2024
1 check passed
@TWilkin TWilkin deleted the 119.voice-assistant-config branch June 13, 2024 18:49
@TWilkin TWilkin linked an issue Jun 13, 2024 that may be closed by this pull request
Reload config on change rather than restart #119
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request voice-assistant Relating to the voice-assistant service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reload config on change rather than restart
1 participant
@TWilkin