#341/#285/#237 Perform ping when turning on computer device #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TWilkin
added
bug
TWilkin
changed the title
This was
linked to
issues
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_turn_onmethod ofComputerDevice.node-controller(node-controller errors in kubernetes #285) by applying same fix asnetwork-controllerused, which was enabling the permission when building the image in theDockerfileand not usingprivileged=False.LocalNodeDevicerather than the service provider.node-controllertests to use fixtures (Switch python controller tests to use fixtures #237 )powerpi-commonwhich will print when a device failed to turn on/off.