Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComputerDevice should ping before returning from turn_on #341

Closed
TWilkin opened this issue Jun 4, 2023 · 0 comments · Fixed by #342 or #344
Closed

ComputerDevice should ping before returning from turn_on #341

TWilkin opened this issue Jun 4, 2023 · 0 comments · Fixed by #342 or #344
Assignees
@TWilkin
Labels
bug Something isn't working network-controller Relating to the network controller service

Comments

@TWilkin
Copy link
Owner

TWilkin commented Jun 4, 2023

ComputerDevice should ping before returning true from turn_on method.
@TWilkin TWilkin added bug Something isn't working network-controller Relating to the network controller service labels Jun 4, 2023
@TWilkin TWilkin self-assigned this Jun 4, 2023
TWilkin added a commit that referenced this issue Jun 4, 2023
@TWilkin
#341 Ping the computer to check if it's on yet
4aba79a
TWilkin added a commit that referenced this issue Jun 4, 2023
@TWilkin
#341 Update test to include new condition
40d7d1a
TWilkin added a commit that referenced this issue Jun 4, 2023
@TWilkin
#341 Make the delay parameterisable to speed the test up
3f9574a
TWilkin added a commit that referenced this issue Jun 4, 2023
@TWilkin
#341 Add delay option to config
459f51d
TWilkin added a commit that referenced this issue Jun 4, 2023
@TWilkin
#341 Make the default delay 10s
4e2a7af
TWilkin added a commit that referenced this issue Jun 4, 2023
@TWilkin
#341 Fix bad log when on/off fails and failing test
6215893
@TWilkin TWilkin mentioned this issue Jun 4, 2023
Merged
TWilkin added a commit that referenced this issue Jun 4, 2023
@TWilkin
#341 More tidy-up
0cc0b1c
TWilkin added a commit that referenced this issue Jun 5, 2023
@TWilkin
Merge pull request #342 from TWilkin/341.ComputerDevice-ping
932f739 
#341/#285/#297 Perform ping when turning on computer device
TWilkin added a commit that referenced this issue Jun 5, 2023
@TWilkin
#341 Fix release version
b00a360
@TWilkin TWilkin mentioned this issue Jun 5, 2023
Merged
@TWilkin TWilkin linked a pull request Jun 5, 2023 that will close this issue
#341 Fix release version #344
Merged
TWilkin added a commit that referenced this issue Jun 5, 2023
@TWilkin
Merge pull request #344 from TWilkin/341.fix-release-version
605cd39 
#341 Fix release version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TWilkin TWilkin

Labels
bug Something isn't working network-controller Relating to the network controller service
Projects
None yet
Milestone
No milestone
1 participant
@TWilkin