Merge pull request #1152 from lochmueller/1146-performance

Fix #1146 - Increase performance in DB compare
TYPO3-Console · Sep 27, 2023 · d6b97fb · d6b97fb
2 parents 466ead4 + c5ddc5f
commit d6b97fb
Showing 1 changed file with 16 additions and 3 deletions.
diff --git a/Classes/Console/Service/Database/SchemaService.php b/Classes/Console/Service/Database/SchemaService.php
@@ -43,10 +43,23 @@ public function __construct(SchemaUpdateInterface $schemaUpdate)
      */
     public function updateSchema(array $schemaUpdateTypes, $dryRun = false)
     {
-        $updateStatements = [
-            SchemaUpdateType::GROUP_SAFE => $this->schemaUpdate->getSafeUpdates(),
-            SchemaUpdateType::GROUP_DESTRUCTIVE => $this->schemaUpdate->getDestructiveUpdates(),
+        $select = [
+            SchemaUpdateType::GROUP_SAFE => false,
+            SchemaUpdateType::GROUP_DESTRUCTIVE => false,
         ];
+        foreach ($schemaUpdateTypes as $schemaUpdateType) {
+            foreach ($schemaUpdateType->getStatementTypes() as $statementGroup) {
+                $select[$statementGroup] = true;
+            }
+        }
+
+        $updateStatements = [];
+        if ($select[SchemaUpdateType::GROUP_SAFE]) {
+            $updateStatements[SchemaUpdateType::GROUP_SAFE] = $this->schemaUpdate->getSafeUpdates();
+        }
+        if ($select[SchemaUpdateType::GROUP_DESTRUCTIVE]) {
+            $updateStatements[SchemaUpdateType::GROUP_DESTRUCTIVE] = $this->schemaUpdate->getDestructiveUpdates();
+        }
 
         $updateResult = new SchemaUpdateResult();