[TASK] Deprecate old command configuration file #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helhum
force-pushed
the
deprecate-old-command-config
branch
from
eedc19c
to
b33416a
Compare
mbrodala
previously requested changes
Sep 4, 2018
helhum
force-pushed
the
deprecate-old-command-config
branch
from
b33416a
to
bada2c8
Compare
helhum
force-pushed
the
deprecate-old-command-config
branch
7 times, most recently
from
165c831
to
4804985
Compare
|
@mbrodala Does it look better now for you? |
At the same time deprecate command controllers registered via ext_localconf.php
helhum
force-pushed
the
deprecate-old-command-config
branch
from
4804985
to
7381a55
Compare
|
Sorry, I barely have time these days. From what I see this looks good. |
|
No worries, thanks for the feedback. Don't hesitate to give further feedback if you have. I will try to adapt then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the same time deprecate command controllers registered
via ext_localconf.php