[BUGFIX] Fix handling of chatty upgrade wizards #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrodala
reviewed
Oct 5, 2018
Tests/Console/Unit/Install/Upgrade/UpgradeWizardExecutorTest.php
Outdated
Show resolved
Hide resolved
mbrodala
reviewed
Oct 8, 2018
helhum
requested changes
Oct 8, 2018
| @@ -80,6 +87,8 @@ public function executeWizard(string $identifier, array $rawArguments = [], bool | |||
| $hasPerformed = $upgradeWizard->performUpdate($dbQueries, $message); | |||
| } | |||
|
|
|||
| $message = trim($message . PHP_EOL . $output->fetch()); | |||
There was a problem hiding this comment.
This overwrites the messages passed as reference to old upgrade wizards.
This line needs to be moved up in the if statement that applies for wizards implementing the new interface.
|
Would also be awesome, if you could add a test that demonstrates the failure and the fix. Thanks a bunch! |
The TYPO3 code introduced a ChattyInterface for upgrade wizards in d336193d86e3c2b99da6d59870f56116277e89c3. When one of those wizards tries to output something it crashes because the output is not initialized. This is fixed by using a BufferedOutput and attaching the collected messages to the upgrade wizard result.
helhum
approved these changes
Oct 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TYPO3 code introduced a ChattyInterface for upgrade
wizards in d336193d86e3c2b99da6d59870f56116277e89c3.
When one of those wizards tries to output something it crashes
because the output is not initialized.
This is fixed by using a BufferedOutput and attaching the collected
messages to the upgrade wizard result.