Update xliff version number in the example code, add xml declaration #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation should reflect best practices given by the following extension which is referenced in other parts of the documentation. https://github.com/TYPO3-Documentation/tea/blob/main/Resources/Private/Language/locallang.xlf Stated best practice for xlf files is to use XLIFF Version 1.2. This should be reflected by the official documentation. Also it makes linting easier. It shouldn't do harm, TYPO3 itself doesn't care about the used version.
|
Since there is no change yet since #387 there is no point in changing the XLIFF version. Please understand that the docs should reflect what TYPO3 actually does and currently TYPO3 uses version 1.0 in all of its files. If you would like to see an update here, please suggest a version bump for TYPO3 first. TYPO3 master XLIFF versionshttps://github.com/TYPO3/TYPO3.CMS/tree/25a9262ae71fa2c10801a63ee8dc92a7a8d12578 |
|
Since the core now adapted to XLF 1.2 I would like to propose re-opening this PR. |
mbrodala
approved these changes
Mar 25, 2021
susannemoog
pushed a commit
that referenced
this pull request
Jun 11, 2021
The documentation should reflect best practices given by the following extension which is referenced in other parts of the documentation. https://github.com/TYPO3-Documentation/tea/blob/main/Resources/Private/Language/locallang.xlf Stated best practice for xlf files is to use XLIFF Version 1.2. This should be reflected by the official documentation. Also it makes linting easier. It shouldn't do harm, TYPO3 itself doesn't care about the used version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best practices for .xlf are given in the following extension which is referenced in other parts of the documentation.
https://github.com/TYPO3-Documentation/tea/blob/main/Resources/Private/Language/locallang.xlf
Stated best practice is to use XLIFF Version 1.2. This should be reflected by the official documentation. Using a recent version also makes linting easier.
It shouldn't do harm, TYPO3 itself doesn't care about the used version.