[FEATURE] Improve file processing #724
Conversation
twoldanski
force-pushed
the
feat/improve-fileprocessing
branch
from
6fc1dfd
to
f749fc5
Compare
Pull Request Test Coverage Report for Build 9033524206Details
💛 - Coveralls |
|
@twoldanski, works like a charm, thanks! |
- new simplified output (off by default) - new options to process files (custom autogenerate feature), filter & alias properties for much cleaned up output. Useful with large sites with a lot of images on page. See options Documentation/Developer/Images.rst - code refactoring - allows to process more image formats Resolves: #247, #617
lukaszuznanski
force-pushed
the
feat/improve-fileprocessing
branch
from
f749fc5
to
0ea41e4
Compare
- new simplified output (off by default) - new options to process files (custom autogenerate feature), filter & alias properties for much cleaned up output. Useful with large sites with a lot of images on page. See options Documentation/Developer/Images.rst - code refactoring - allows to process more image formats - add additional tests Resolves: #247, #617
| $image, | ||
| array_merge( | ||
| ['fileExtension' => $fileExtension], |
There was a problem hiding this comment.
this change results into the images won´t be reused by ProcessedFileRepository::235, because the missing fileExtension results into another configurationsha1 and on each request the image is processed
|
@twoldanski @lukaszuznanski how we should proceed here? reimplement the fileExtension only? What was the reason that it got removed? |
|
@develth can create new issue? It was not removed, it should be applied. You have issue with 4.3.2? Also please provide example typoscript you are using. |
@twoldanski from the marked line, the fileExtension is removed. Do not see any part where it should get applied before fetchin a already processed media?
Yes, had issues until i braught back fileExtension in my overridden GalleryProcessor |
|
Created an Issue: |
Resolves: #247, #617