[!!!][TASK] Split SolrService into SolrAdminService, SolrReadService and SolrWriteService #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timohund
force-pushed
the
task/master/1745-split-SolrService-into-read-write-admin
branch
4 times, most recently
from
f8c5a3a
to
d553ad7
Compare
timohund
changed the title
timohund
force-pushed
the
task/master/1745-split-SolrService-into-read-write-admin
branch
from
d553ad7
to
2ef302c
Compare
…and SolrWriteService This pr: * Extracts the SolrAdminService, SolrReadService and SolrWriteService from the SolrService. * Changes the SolrConnectionManager to return a SolrConnection that could be used to access these services. * Allows as followup to differnciate between read and write connections an to send them to different solr servers (master/slave) Impact: The ConnectionManager now return a SolrConnection that has the methods "getReadService", "getWriteService" and get "getAdminService". These Services contain the corresponding method from the previous SolrService. Fixes: TYPO3-Solr#1745
timohund
force-pushed
the
task/master/1745-split-SolrService-into-read-write-admin
branch
from
2ef302c
to
eef6386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr:
Impact:
The ConnectionManager now return a SolrConnection that has the methods "getReadService", "getWriteService" and get "getAdminService".
These Services contain the corresponding method from the previous SolrService.
Fixes: #1745