Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Ensure AjaxController returns a response #1875

Merged
merged 2 commits into from
Mar 6, 2018

Conversation

bmack
Copy link
Collaborator

@bmack bmack commented Mar 6, 2018

In TYPO3 v9, all Routes should return a PSR-7 compatible Response object.

However "updateConnections" does not do so, resulting in a PHP error.

Also valid for EXT:solr v8.0.1

In TYPO3 v9, all Routes should return a PSR-7 compatible Response object.

However "updateConnections"  does not do so, resulting in a PHP error.
@timohund timohund added this to the 8.1 - Latest Apache Solr Version milestone Mar 6, 2018
@timohund timohund self-requested a review March 6, 2018 08:33
@timohund
Copy link
Contributor

timohund commented Mar 6, 2018

@bmack Thanks for the patch

@timohund timohund merged commit 06d0637 into TYPO3-Solr:master Mar 6, 2018
timohund pushed a commit to timohund/ext-solr that referenced this pull request Mar 6, 2018
* [BUGFIX] Ensure AjaxController returns a response

In TYPO3 v9, all Routes should return a PSR-7 compatible Response object.

However "updateConnections"  does not do so, resulting in a PHP error.

* Return an empty Response object for ClearCacheMenu item
timohund added a commit that referenced this pull request Mar 6, 2018
* [BUGFIX] Ensure AjaxController returns a response

In TYPO3 v9, all Routes should return a PSR-7 compatible Response object.

However "updateConnections"  does not do so, resulting in a PHP error.

* Return an empty Response object for ClearCacheMenu item
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants