[TASK] Integrate phpstan #3639
Merged
[TASK] Integrate phpstan #3639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds phpstan for static code analysis. The current code base (especially the tests), define wrong phpdoc comments, which is the main work to achieve in this patch. In order to make tests / mocking behaviour easier, the phpunit extension is also installed. For this reason, the "getDumbMock" need to be removed for "createMock" from phpunit. The test can be executed like this: * composer install --prefer-source * composer tests:phpstan
dkd-kaehm
approved these changes
May 26, 2023
dkd-friedrich
pushed a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Feb 29, 2024
dkd-friedrich
pushed a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Feb 29, 2024
dkd-friedrich
pushed a commit
that referenced
this pull request
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
This change adds phpstan for static code analysis.
The current code base (especially the tests),
define wrong phpdoc comments, which is the main work to achieve in this patch.
In order to make tests / mocking behaviour easier, the phpunit extension is also installed.
For this reason, the "getDumbMock" need to be
removed for "createMock" from phpunit.
How to test
The test can be executed like this:
Fixes: #3632