Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Integrate phpstan #3639

Merged
merged 9 commits into from
May 26, 2023
Merged

[TASK] Integrate phpstan #3639

merged 9 commits into from
May 26, 2023

Commits on May 16, 2023

  1. [TASK] Integrate phpstan 

    This change adds phpstan for static code analysis.

The current code base (especially the tests),
define wrong phpdoc comments, which is the main work
to achieve in this patch.

In order to make tests / mocking behaviour easier,
the phpunit extension is also installed.

For this reason, the "getDumbMock" need to be
removed for "createMock" from phpunit.

The test can be executed like this:

* composer install --prefer-source
* composer tests:phpstan
    @bmack
    bmack committed May 16, 2023
    Configuration menu
    Copy the full SHA
    56f4a80 View commit details
    Browse the repository at this point in the history

  2. [TASK] Migrate more unit tests to clean API and make unit tests work … 

    …again
    @bmack
    bmack committed May 16, 2023
    Configuration menu
    Copy the full SHA
    fb576a1 View commit details
    Browse the repository at this point in the history

  3. [TASK] Fix more phpstan issues

    @bmack
    bmack committed May 16, 2023
    Configuration menu
    Copy the full SHA
    0827e5e View commit details
    Browse the repository at this point in the history

  4. [TASK] Fix more phpstan issues and remove scrutinizer information

    @bmack
    bmack committed May 16, 2023
    Configuration menu
    Copy the full SHA
    643510e View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. [TASK] Update all code pieces for phpstan within Tests folder

    @bmack
    bmack committed May 25, 2023
    Configuration menu
    Copy the full SHA
    0d770f7 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. [TASK] Update all code pieces for phpstan within Classes/ folder

    @dkd-kaehm
    dkd-kaehm committed May 26, 2023
    Configuration menu
    Copy the full SHA
    7c58c86 View commit details
    Browse the repository at this point in the history

  2. [TASK] remove scritinizer static analyse fixes from sources

    @dkd-kaehm
    dkd-kaehm committed May 26, 2023
    Configuration menu
    Copy the full SHA
    6ce39ef View commit details
    Browse the repository at this point in the history

  3. [TASK] Run PHPStan analysis within CI 

    Fixes: TYPO3-Solr#3632
    @dkd-kaehm
    dkd-kaehm committed May 26, 2023
    Configuration menu
    Copy the full SHA
    ea7f0bc View commit details
    Browse the repository at this point in the history

  4. [TASK] Minimize footprint of composer dependencies

    @dkd-kaehm
    dkd-kaehm committed May 26, 2023
    Configuration menu
    Copy the full SHA
    2988f32 View commit details
    Browse the repository at this point in the history