-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TemplateCompiler::has() must use sanitized identifier #320
Comments
sascha-egerer
pushed a commit
to sascha-egerer/Fluid
that referenced
this issue
Jul 26, 2017
Instances are stored with the sanitzied identifier into a runtime cache. The `TemplateCompiler::has()` must also use the sanitzed version of the identifier to check if the instance exists in the runtime cache. Resolves TYPO3#320
sascha-egerer
pushed a commit
to sascha-egerer/Fluid
that referenced
this issue
Jul 26, 2017
Instances are stored with the sanitzied identifier into a runtime cache. The `TemplateCompiler::has()` must also use the sanitzed version of the identifier to check if the instance exists in the runtime cache. Resolves TYPO3#320
sascha-egerer
pushed a commit
to sascha-egerer/Fluid
that referenced
this issue
Jul 26, 2017
Instances are stored with the sanitzied identifier into a runtime cache. The `TemplateCompiler::has()` must also use the sanitzed version of the identifier to check if the instance exists in the runtime cache. Resolves TYPO3#320
opi99
pushed a commit
to opi99/Fluid
that referenced
this issue
Jan 8, 2018
Instances are stored with the sanitzied identifier into a runtime cache. The `TemplateCompiler::has()` must also use the sanitzed version of the identifier to check if the instance exists in the runtime cache. Resolves TYPO3#320
lolli42
pushed a commit
that referenced
this issue
Feb 5, 2018
* [TASK] Use the Trusty build environment on Travis (#314) * [TASK] Remove test coverage of HHVM from travis.yml (#323) Resolves: #322 * [BUGFIX] Fix getLayoutPathAndFilename behavior in TemplatePaths (#309) Class TemplatePaths will now correctly return the class variable layoutPathAndFilename if it was set before. Close: #309 * [BUGFIX] Use sanizted identifier in TemplateCompiler::has() (#321) Instances are stored with the sanitzied identifier into a runtime cache. The `TemplateCompiler::has()` must also use the sanitzed version of the identifier to check if the instance exists in the runtime cache. Resolves #320 * require and include are statements (#316) * [BUGFIX] Prevent re-loading cached classes that already exist (#315) This patch prevents a problem where it is made up to the individual cache implementation whether or not to re-load a class file when a class is already defined. Instead, making the compiler only fetch the class from cache if it is not already loaded (by checking class_exists without allowing autoloading!) prevents re-loading classes with “class already declared” errors to follow. * [TASK] Throw ViewHelper exception in f:count on uncountable subject (#296) * [TASK] Use (float) and (int) (#313) * [BUGFIX] Do not attempt to escape non-string or -compatible values (#285) Avoids calling htmlspecialchars() on incompatible values. Changes compiling of the escaping node to generate a small closure which checks for string or string-compatible value before escaping. * [BUGFIX] Handle adding namespaces to ignored namespaces (#283) Corrects the following two misbehaviors: 1. A second call to add a namespace with a `null` value causes an error; expected: silently keep ignoring namespace. 2. A second call to add a namespace that was previously ignored causes an error; expected: converts ignored namespace to active. Fixes: #282 * [TASK] Fix typo in unknown namespace exception message (#326) * [BUGFIX] Make casting of numbers the same in arguments and arrays (#333) Problem briefly described: numbers passed in tag attributes vs. numbers passed in inline syntax (which internally uses the array syntax parsing) handles numeric values in two different ways: * In tags, a NumericNode is created if is_numeric is true * In arrays, numbers are cast with (float) and matched by regexp NumericNode also casts the value but does so by using an add zero trick which makes PHP do the casting based on string value, and the input is always a string in the parser. This means that the two different ways of passing a number will produce two different types of variables given natural numbers as input. Passing floats still causes the same type. The solution is to apply the same method of casting in both cases. * [BUGFIX] Make ViewHelperResolver internal cache non-static (#328) Using a static class property for the cache could have bad side effects for setups which have multiple contexts for Fluid and may change the namespaces between contexts. Converting the cache to a non-static property cleans it properly when a new ViewHelperResolver is created. * [BUGFIX] Remove incorrect throws annotation (#355) Exception class doesn't exist, * [TASK] Add PHP 7.2 to travis (#363)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
TemplateCompiler::has()
method does not use the sanitized identifier to check if there is an instance in thesyntaxTreeInstanceCache
.As the instance is stored with the sanitized identifier this will never match.
The text was updated successfully, but these errors were encountered: