Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

function peek() in BooleanParser.php runs in an endless loop #667

Closed
birgitberlin opened this issue Nov 2, 2022 · 2 comments · Fixed by #821
Closed

function peek() in BooleanParser.php runs in an endless loop #667

birgitberlin opened this issue Nov 2, 2022 · 2 comments · Fixed by #821

Comments

@birgitberlin
Copy link

Fatal error: Maximum execution time of 240seconds exceeded in typo3_src-10.4.32/vendor/typo3fluid/src/Core/Parser/BooleanParser.php on line 155

The cause of the error was a missing single quote in a condition:
<f:if condition="{pageClass} == 'myClass">
@hdietrich-timespin
Copy link

hdietrich-timespin commented Aug 28, 2023 •
edited

correlated issue: https://forge.typo3.org/issues/101692#change-499952

s2b added a commit that referenced this issue Oct 16, 2023
@s2b
[BUGFIX] Prevent infinite loop in BooleanParser
93282fe 
This change prevents an infinite loop if single or double
quotes in boolean expressions are not properly closed.

Resolves: #667
@s2b s2b mentioned this issue Oct 16, 2023
Merged
s2b added a commit that referenced this issue Oct 16, 2023
@s2b
[BUGFIX] Prevent infinite loop in BooleanParser
ddf375c 
This change prevents an infinite loop if single or double
quotes in boolean expressions are not properly closed.

Resolves: #667
@s2b s2b closed this as completed in 7d0b084 Oct 30, 2023
@s2b
Copy link
Contributor

s2b commented Nov 14, 2023

We just released Fluid v2.9.3 which includes the bugfix and can be installed with composer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] Prevent infinite loop in BooleanParser TYPO3/Fluid
3 participants
@s2b @birgitberlin @hdietrich-timespin