[BUGFIX] Fix ternary condition behaviors #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch corrects the following problems for ternary conditions: * Dotted paths were not detected correctly. * The “then” part was mandatory * Negating the condition did not work correctly All three described cases are working now.
mbrodala
reviewed
Jul 9, 2018
| @@ -10,7 +10,12 @@ | |||
| <f:else>Not touched</f:else> | |||
| </f:if> | |||
|
|
|||
| Ternary expression: {checkTernary ? ternaryTrue : ternaryFalse} | |||
| Ternary expression without then case: {ternaryTrue ? : ternaryFalse} | |||
There was a problem hiding this comment.
I assume this also works with ?: instead of ? :? If yes, then we should prefer that since that's the common notation in PHP.
There was a problem hiding this comment.
Works both without and with any number and type of spaces between the parts.
Avoid people thinking that spaces are necessary here.
mbrodala
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch corrects the following problems for
ternary conditions:
All three described cases are working now.
Fixes: #148