Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Improve performance of Escape interceptor #716

Merged
merged 3 commits into from
May 2, 2023
Merged

[TASK] Improve performance of Escape interceptor #716

merged 3 commits into from
May 2, 2023

Conversation

IndyIndyIndy
Copy link
Contributor

@IndyIndyIndy IndyIndyIndy commented Apr 28, 2023 •
edited

Resolves: #715

This change simply introduces the performance improvements already done by Claus Due in v3 to v2.x.
See 6053dcb

@lolli42 lolli42 merged commit a1d2da5 into TYPO3:main May 2, 2023
6 checks passed
lolli42 added a commit that referenced this pull request Jun 6, 2023
@lolli42
Revert "[TASK] Improve performance of Escape interceptor (#716)"
613a6ac 
This reverts commit a1d2da5.

The patch has side effects when the node being escaped is
changed to an instance of EscapingNode, so especially the
check

if (end($this->viewHelperNodesWhichDisableTheInterceptor) === $node) {

needs to be kept.

Reverts #715
lolli42 added a commit that referenced this pull request Jun 6, 2023
@lolli42
Revert "[TASK] Improve performance of Escape interceptor (#716)" (#799)
553da54 
This reverts commit a1d2da5.

The patch has side effects when the node being escaped is
changed to an instance of EscapingNode, so especially the
check

if (end($this->viewHelperNodesWhichDisableTheInterceptor) === $node) {

needs to be kept.

Reverts #715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolli42 lolli42 lolli42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve performance of Escape interceptor
2 participants
@IndyIndyIndy @lolli42