[TASK] Avoid and deprecate ParserRuntimeOnly trait #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This trait has been added with 127d8e7 for no apparent reason: It was used three times with one consumer overriding the render() method again. There is no point to have a trait for methods that only return null or empty strings. To simplify the construct a bit, the trait is avoided and marked as @deprecated. Neither Flow nor TYPO3 use the trait in own VH's, impact should be quite small.
sbuerk
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This trait has been added with 127d8e7 for
no apparent reason: It was used three times
with one consumer overriding the render()
method again. There is no point to have a
trait for methods that only return null
or empty strings.
To simplify the construct a bit, the trait
is avoided and marked as @deprecated. Neither
Flow nor TYPO3 use the trait in own VH's,
impact should be quite small.