[TASK] Avoid RenderingContextFixture #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of test subjects carry the rendering context around and access it to perform things. The "god" test fixture RenderingContextFixture is used to mock-away this dependency in tests. This is however hard to understand and adds complexity to tests. The patch uses RenderingContext directly in most cases, or switches to mocks of the RenderingContextInterface. Strictly speaking, this makes some "unit" tests de facto integration / functional tests, but moving tests around or refactoring to mock RenderingContext again is a task for further patches. For now, this patch should make various tests easier to understand and follow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of test subjects carry the rendering
context around and access it to perform
things.
The "god" test fixture RenderingContextFixture
is used to mock-away this dependency in tests.
This is however hard to understand and adds
complexity to tests.
The patch uses RenderingContext directly in
most cases, or switches to mocks of the
RenderingContextInterface.
Strictly speaking, this makes some "unit" tests
de facto integration / functional tests, but
moving tests around or refactoring to mock
RenderingContext again is a task for further
patches.
For now, this patch should make various tests
easier to understand and follow.