[TASK] Optimize compiled code of condition VHs #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AbstractConditionViewHelper based VH's take care of children on their own. There is no need to have them within compiled PHP code a second time. The patch adds a custom convert() method to AbstractConditionViewHelper that optimizes the generated PHP code accordingly. This has a huge impact especially on f:if with large bodies in practice, generated compiled template code can shrink by half in size. Resolves: #771
sbuerk
approved these changes
May 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AbstractConditionViewHelper based VH's take
care of children on their own. There is no need
to have them within compiled PHP code a second
time.
The patch adds a custom convert() method to
AbstractConditionViewHelper that optimizes
the generated PHP code accordingly.
This has a huge impact especially on f:if with
large bodies in practice, generated compiled
template code can shrink by half in size.
Resolves: #771