[TASK] Optimize compiled code of some VHs #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a couple of view helpers that never
render the body closure as such. Those still
create unused code within compiled templates.
We can shortcut compilation in these VH's a
bit to create smaller compiled templates.
The patch has a huge positive effect on
compiled templates sizes especially due
to the f:section change, which until now
contained the entire body of each section
within the files twice.
f:comment - Obviously, comments are never rendered.
f:layout - Layouts are resolved at a different
level and the VH has no support for
different children.
f:section - Sections are resolved at a different
level and called via f:render. It's
compiled variant does not need to
take care of bodies itself.
sbuerk
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of view helpers that never
render the body closure as such. Those still
create unused code within compiled templates.
We can shortcut compilation in these VH's a
bit to create smaller compiled templates.
The patch has a huge positive effect on
compiled templates sizes especially due
to the f:section change, which until now
contained the entire body of each section
within the files twice.
f:comment - Obviously, comments are never rendered. f:layout - Layouts are resolved at a different
level and the VH has no support for
different children.
f:section - Sections are resolved at a different
level and called via f:render. It's
compiled variant does not need to
take care of bodies itself.