Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Ensure path order with duplicates #805

Closed
wants to merge 1 commit into from

Conversation

s2b
Copy link
Contributor

@s2b s2b commented Jun 16, 2023

No description provided.

@sbuerk
Copy link
Contributor

sbuerk commented Jun 18, 2023

@s2b Can you please:

  • Add some more description to the pull-request
  • Add some commit message describing it
  • or at least add and reference an issue

There is nothing which can be read why what is expected
and why this should be considered as bug. Especially why
the chosen solution is the correct way o fix it. Or
better to say why the behaviour should be the expected
behaviour.

Just from the code, I'm not quite sure if everyone would
follow what you postulated by code here and why it is fixed
the way you do it.

Not sure if this this is really a bug or more a feature.

It's debatable if a later re-announcing a already added
path should change the order. It may be your use-case,
but is it really a valid expectation in all cases ?

This is a drastically change in behaviour. Could be that
this should be handled more by the consumer to deside
how to merge multiple ways of path configurations ?

@s2b
Copy link
Contributor Author

s2b commented Jun 18, 2023

Sorry, this was meant as a draft to check if this fixes https://forge.typo3.org/issues/81099. I‘ll add more information later.

@s2b s2b marked this pull request as draft June 18, 2023 16:13
@s2b
Copy link
Contributor Author

s2b commented Sep 1, 2023

This has been fixed in TYPO3 now, so this is no longer relevant

@s2b s2b closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants