Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use predefined packages for testing #768

Closed
wants to merge 1 commit into from

Conversation

koehnlein
Copy link
Contributor

@koehnlein koehnlein commented May 24, 2023

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added (for bug fixes / features)

The complete PR is about testing 馃槃 But I'm pretty sure, the tests will fail when merged ...

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fix tests

  • What is the current behavior? (You can also link to an open issue here)

Because of the existing composer.lock file and the definition of PHP 7.4 in the composer.json, the tests in the pipeline are always based on the predefined packages. This results in surf not being tested with newer packages that would be used if someone installs surf into their environment via composer.

  • What is the new behavior (if this is a feature change)?

Delete the composer.lock file, which allows the pipeline to install latest packages.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

It does not affect any user's installation, but I'm pretty sure, the tests will fail, because there are some problems with newer einvironments (see #760)

  • Other information:

@koehnlein koehnlein marked this pull request as ready for review May 24, 2023 11:38
@koehnlein koehnlein changed the title Do not use predefined packages for testing Draft: Do not use predefined packages for testing May 24, 2023
@koehnlein koehnlein marked this pull request as draft May 24, 2023 11:54
@koehnlein koehnlein changed the title Draft: Do not use predefined packages for testing Do not use predefined packages for testing May 24, 2023
@sabbelasichon
Copy link
Collaborator

@koehnlein Thanks for your investigation. I have created a separated complete PR #770 based on your changes. I think we should give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants