[BUGFIX] Make compatible with psr/log:^3 #769
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, no tests have been added yet. And I'm a bit unsure about the best way to test it. I found out that all tests are run with a predefined composer.lock file and I don't know if that is intentional or not. I started another PR for it: #768
Limit package "psr/log" to "^1.0 || ^2.0"
In dad4d15, the package "monolog/monolog" was upgraded and the new version of "monolog/monolog" requires "psr/log":"^1.0 || ^2.0 || ^3.0" - But Surf ist not compatible with psr/log:^3
See also #760
The new behavior is to only install psr/log in version 1 or 2
No, it doesn't.
I also tried to make Surf compatible with psr/log:^3 but I would have needed to change https://github.com/TYPO3/Surf/blob/master/src/Domain/Model/Deployment.php#LL288C29-L288C29 from
to
Which would have been a breaking change.